add explanation about argument name uniquess.#739
add explanation about argument name uniquess.#739dugenkui03 wants to merge 1 commit intographql:mainfrom dugenkui03:patch-2
Conversation
benjie
left a comment
There was a problem hiding this comment.
I think it would make sense to do these assertions in the same order as fields; i.e.
- Unique
- No
__ - Type check
thanks for you suggestion, it does more readable. |
|
Marking this proposal as Stage 1. Next steps are making sure this has a reflecting PR to the graphql.js reference implementation |
e5d241d to
6c81ed8
Compare
|
Hi @leebyron @IvanGoncharov,would you be willing to merge this pr directly, or this process must finish in stage 3. I think it's a pretty simple supplementary explanation: the graphql implementation of various languages must obey it, but specification haven't written it directly. In fact, we can infer these validation rules from the specification. |
@dugenkui03 We need to go full process. I actually forgot about this PR so when working on graphql/graphql-wg#505 I independently did the same changes in #877 |
|
❌ Deploy Preview for graphql-spec-draft failed. 🔨 Explore the source changes: 3fcc954 🔍 Inspect the deploy log: https://app.netlify.com/sites/graphql-spec-draft/deploys/615e6aead8f9fa00072207cb |
@IvanGoncharov Thanks for your response. After |
|
@dugenkui03 Thanks, closing in favor of #891 |
Add explanation about argument name uniquess.