Skip to content

Conversation

@martinbonnin
Copy link
Contributor

Update solution 6. As I understand, it also relies on a request parameter as well as introspection changes.

Also added my name as a champion here since it was empty. If anyone feels strongly about this solution, I'm happy to relinquish the "championability"!

@benjie
Copy link
Member

benjie commented Mar 28, 2025

I've been acting champion of this (e.g. here), and if it's the solution that we select then I plan to implement it on top of the work I've already done. To me, * and @semanticNonNull are variants of the same proposal, only really differing in terms of the syntax through which they're exposed. That said, if we get it down to * vs @semanticNonNull I will be arguing for * so it makes sense for you to champion @semanticNonNull against me if you truly feel it's the superior solution 👍

martinbonnin and others added 4 commits March 28, 2025 22:43
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
Co-authored-by: Benjie <benjie@jemjie.com>
@martinbonnin
Copy link
Contributor Author

martinbonnin commented Mar 28, 2025

I've been acting champion of this (e.g. #1700 (comment)), and if it's the solution that we select then I plan to implement it on top of the work I've already done.

Excellent 👍 No need for 2 champions there, especially since you know the implementation already. I was mainly filling the void. I made you the champion.

@benjie benjie merged commit 5629792 into graphql:main Mar 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants