-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update Events page a bit #2180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Events page a bit #2180
Conversation
|
@hasparus is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
||
| {/* | ||
| ## Events | ||
| ## Upcoming Events |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit annoying, but we can't conditionally render this heading, because it won't landing in ToC.
Heading scanning should be handled by rehype on the final HTML, not in remark layer, but it's a detail and it won't look bad till December.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Description as @jemgillam raised in #2180 (comment), the new event cards are too big for normal sized phones. I tested it on a wider model, and we didn't consider smaller variants in Figma. I've made the cards smaller on screens narrower than 394px and I added negative margin and some padding to use the whole screen width for the events lists. (We're still using those cards, but colored, in newly updated designs, so this work is also gonna help me in the future.) <img width="514" height="659" alt="image" src="https://github.com/user-attachments/assets/5fa2619b-d3d7-4dba-bd1e-ef5665759a32" /> <img width="462" height="211" alt="image" src="https://github.com/user-attachments/assets/713444bb-033b-4946-bab4-23dd004388ea" />

Description
Howdy,
cc @Urigo you promised me a review today on the call :)
Differences from designs
I made the spacing in the cards a little bit smaller because we don't have as much room here in the docs as in the Events landing page they were initially designed for.
Screen.Recording.2025-10-14.at.20.17.34.mov