404 footer navbar #2219
Merged
404 footer navbar #2219
+1,493
−791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hasparus is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jonathanawesome
approved these changes
Nov 6, 2025
Contributor
jonathanawesome
left a comment
jonathanawesome
left a comment
There was a problem hiding this comment.
Fantastic work! This is a major block-remover that will allow us to start migrating from pages router to app.
src/components/navbar/navbar.tsx
Outdated
| type ReactNode, | ||
| } from "react" | ||
| import React, { useEffect, type ReactElement, type ReactNode } from "react" | ||
| import { useMenu, useThemeConfig } from "nextra-theme-docs" |
Contributor
There was a problem hiding this comment.
useThemeConfig is unused
src/components/footer/index.tsx
Outdated
| </div> | ||
| <p className="typography-body-xs flex flex-col text-pretty max-md:gap-5"> | ||
| {renderComponent(themeConfig.footer.content)} | ||
| Copyright © 2025 The GraphQL Foundation. All rights reserved. |
Contributor
There was a problem hiding this comment.
can we do new Date().getFullYear() here?
Urigo
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also made the text match highlight bright neutral with underline (like in Fumadocs) instead of primary as it's more legible on blurred background.
Added a navbar and footer to the 404 page.
Had to eject the search input from Nextra (but we talked with designers about restyling it anyway, so this is a first step.).