You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@griest024 should this also be added to readme headings too? (e.g. design component docs, guides docs)
Yes but those are markdown rendered and so it's more complicated to do so. We could expose the heading component as a custom element and then customize the markdown rendering of headings.
@griest024 should this also be added to readme headings too? (e.g. design component docs, guides docs)
Yes but those are markdown rendered and so it's more complicated to do so. We could expose the heading component as a custom element and then customize the markdown rendering of headings.
@griest024 should this also be added to readme headings too? (e.g. design component docs, guides docs)
Yes but those are markdown rendered and so it's more complicated to do so. We could expose the heading component as a custom element and then customize the markdown rendering of headings.
Do you want to do this in a separate PR?
Yeah I think so. Custom elements opens a can of worms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes: #3895, fixes: #3893, fixes: #3894
What is the new behavior?
Does this PR introduce a breaking change?
Other information