fix(desktop): suppress Windows command consoles - #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CREATE_NO_WINDOWhandling at the final shared process spawn boundaryRoot cause
The target lifecycle refactor moved Windows process creation into
process-wrap. The packaged execution path no longer applied the previously provenCommandExt::creation_flagsbehavior at the final spawn boundary, causing console windows to appear for startup probes, rechecks, andOpen VidXP.Impact
Installed Windows desktop builds launch all VidXP command flows without opening terminal windows. Probe cancellation and exact-child process-tree supervision remain intact.
Validation
cargo +1.97.1 test --manifest-path desktop/src-tauri/Cargo.toml— 72 passedcargo +1.97.1 clippy --manifest-path desktop/src-tauri/Cargo.toml --all-targets -- -D warningscargo +1.97.1 fmt --manifest-path desktop/src-tauri/Cargo.toml -- --checkgit diff --checkBEGIN_COMMIT_OVERRIDE
fix(desktop): prevent console windows during background operations
END_COMMIT_OVERRIDE