Skip to content

fix(desktop): suppress Windows command consoles - #52

Merged
tulayha merged 1 commit into
mainfrom
fix/windows-hidden-processes
Aug 2, 2026
Merged

fix(desktop): suppress Windows command consoles#52
tulayha merged 1 commit into
mainfrom
fix/windows-hidden-processes

Conversation

@tulayha

@tulayha tulayha commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • restore explicit Windows CREATE_NO_WINDOW handling at the final shared process spawn boundary
  • keep Job Object supervision by starting children suspended until whole-tree ownership is established
  • cover both captured probe/recheck commands and long-lived service commands

Root cause

The target lifecycle refactor moved Windows process creation into process-wrap. The packaged execution path no longer applied the previously proven CommandExt::creation_flags behavior at the final spawn boundary, causing console windows to appear for startup probes, rechecks, and Open VidXP.

Impact

Installed Windows desktop builds launch all VidXP command flows without opening terminal windows. Probe cancellation and exact-child process-tree supervision remain intact.

Validation

  • cargo +1.97.1 test --manifest-path desktop/src-tauri/Cargo.toml — 72 passed
  • cargo +1.97.1 clippy --manifest-path desktop/src-tauri/Cargo.toml --all-targets -- -D warnings
  • Windows captured-command console assertion
  • Windows service-command console assertion
  • focused Release Please version-marker packaging test
  • cargo +1.97.1 fmt --manifest-path desktop/src-tauri/Cargo.toml -- --check
  • git diff --check

BEGIN_COMMIT_OVERRIDE
fix(desktop): prevent console windows during background operations
END_COMMIT_OVERRIDE

@tulayha
tulayha marked this pull request as ready for review August 2, 2026 13:57
@tulayha
tulayha merged commit 42da9a5 into main Aug 2, 2026
6 checks passed
@github-actions github-actions Bot mentioned this pull request Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant