lf_ftp.py — Robot/band-steering resilience to unresponsive devices + cleaner missing-CX logging - #326
Merged
Conversation
…sive Signed-off-by: Sidartha-CT <neelapu.sidartha@candelatech.com>
haricharan-candela
requested review from
goyalsaurabh06,
haricharan-candela and
litincandela
August 3, 2026 07:37
haricharan-candela
approved these changes
Aug 3, 2026
haricharan-candela
left a comment
haricharan-candela
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, suggested nits and update the description with summary of changes made
Sidartha-CT
changed the title
…nate Signed-off-by: Sidartha-CT <neelapu.sidartha@candelatech.com>
…esponding Signed-off-by: Sidartha-CT <neelapu.sidartha@candelatech.com>
…esponding Signed-off-by: Sidartha-CT <neelapu.sidartha@candelatech.com>
…ssing Verified CLI : python3 lf_ftp.py --ssid "SSID" --passwd sharedsecret --file_sizes 5MB --mgr "192.168.245.117" --traffic_duration 1M --security wpa2 --directions Download --clients_type Real --bands 5G --upstream_port eth2 --twog_radio wiphy0 --device_list 1.26,1.109 Signed-off-by: Sidartha-CT <neelapu.sidartha@candelatech.com>
Sidartha-CT
force-pushed
the
ftp_updates
branch
from
August 3, 2026 08:11
8982f26 to
b302c34
Compare
goyalsaurabh06
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR:
lf_ftp.py— Robot/band-steering resilience to unresponsive devices + cleaner missing-CX loggingCommits:
bdeafed5→8982f268What's handled
All devices go unresponsive during monitoring (
bdeafed5)Instead of hanging indefinitely, the monitor loop now retries for up to 40s (
wait_for_any_cx_recovery), then gives up gracefully and stops the robot/band-steering run early, using whatever data was already collected.Band-steering's coordinate loop and the plain robot coordinate/rotation loop both check
all_devices_stoppedand break out cleanly instead of continuing to move the robot.Grace-period timing differs by test mode (
3439f307)Band-steering calls
monitor_for_runtime_csv()repeatedly within one continuous session, somonitoring_start_timeis set once.Plain robot coordinate/rotation tests call it once per coordinate with CXs freshly restarted each time, so the grace period now resets on every call instead of only the first.
WebUI left in a stale "in progress" nav state (
5ccf7acb)When the 40s recovery wait times out on a robot test,
update_nav_data_for_all_cxs_stopped()is now called so the WebUI shows the run as completed rather than stuck on a step that will never be reached.Crash when band steering ends after all devices stop (
2c1d6daa)monitor_for_runtime_csv()now:self.datagets reset, so the last good snapshot survives forstop()to read),start_time/end_timedefensively in casetraffic_duration <= 0,end_timeinstead of the never-reached planned end.Missing-CX warning dumped the entire nested API response (
8982f268)Now logs just the CX names present in the response, making the log readable instead of printing the full stats dict for every connection.
Net effect
Robot/band-steering FTP tests degrade gracefully (stop early, keep partial data, update WebUI state, no crash) when devices disconnect mid-test, and diagnostic logging for missing CXs is now scannable at a glance.