fix installer silently keeping a stale codescribe symlink - #35
Merged
gsokoll merged 2 commits intoAug 5, 2026
Merged
Conversation
CreateSymbolicLinkW fails with ERROR_ALREADY_EXISTS when the codescribe link is already present, and the return value was discarded. Re-running the installer therefore left the old symlink untouched while still overwriting config.json, so a config listing new commands could point into an outdated checkout that lacks the corresponding scripts. - remove any existing codescribe symlink before recreating it, and refuse to continue if the path exists but is not a symlink - check the CreateSymbolicLinkW return value, loading kernel32 with use_last_error so get_last_error works, and declaring restype as BOOLEAN rather than the default int - report ERROR_PRIVILEGE_NOT_HELD as the existing 'are you running as administrator?' message, which previously printed success instead - create the symlink before backing away config.json, so a failed install leaves the previous one intact Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
exists() and is_symlink() both report False for a junction whose target is gone, so remove_existing_symlink fell through both branches and CreateSymbolicLinkW later failed with a bare error code 183. Probe the path with lstat instead, which sees the reparse point itself, and refuse with an actionable message for junctions and other non-symlink reparse points.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateSymbolicLinkW fails with ERROR_ALREADY_EXISTS when the codescribe link is already present, and the return value was discarded. Re-running the installer therefore left the old symlink untouched while still overwriting config.json, so a config listing new commands could point into an outdated checkout that lacks the corresponding scripts.