This repository was archived by the owner on Nov 9, 2017. It is now read-only.
feat : add a filtered $on, allowing easy filtering and optimization#5
Merged
gregberge merged 3 commits intogregberge:masterfrom Sep 10, 2015
Yvem:20150908-add_an_early_on_filtering_feature
Merged
feat : add a filtered $on, allowing easy filtering and optimization#5gregberge merged 3 commits intogregberge:masterfrom Yvem:20150908-add_an_early_on_filtering_feature
gregberge merged 3 commits intogregberge:masterfrom
Yvem:20150908-add_an_early_on_filtering_feature
Conversation
gregberge
added a commit
that referenced
this pull request
Sep 10, 2015
…ature feat : add a filtered $on, allowing easy filtering and optimization
Owner
|
@Yvem readme needs some documentation, if you have time... Or I will do it later. Thanks for the PR. |
Owner
|
Released in 1.0.0. |
Contributor
Author
|
@neoziro sorry for the missing doc |
Merged
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factor a common filtering case when handling a primus event.
Bonus : apply() is not called if the event is filtered out, greatly helping heavy AngularJS apps.
Design note : add another function instead of extending $on, for readibility and to avoid complex arguments manipulation
Note : this PR adds a dependency to lodash