This repository was archived by the owner on Nov 9, 2017. It is now read-only.
feat(perfs): use $evalAsync() for calling listeners in an optimized way#7
Merged
gregberge merged 1 commit intogregberge:masterfrom Sep 14, 2015
Merged
feat(perfs): use $evalAsync() for calling listeners in an optimized way#7gregberge merged 1 commit intogregberge:masterfrom
gregberge merged 1 commit intogregberge:masterfrom
Conversation
Owner
|
@Yvem je te fais confiance |
gregberge
added a commit
that referenced
this pull request
Sep 14, 2015
feat(perfs): use $evalAsync() for calling listeners in an optimized way
Contributor
Author
|
@neoziro thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This optimization is the correct way to do it and makes #5 nearly useless.
See http://www.bennadel.com/blog/2751-scope-applyasync-vs-scope-evalasync-in-angularjs-1-3.htm for details.
If you have 10 listeners for the same event (which happen in heavy apps), those 10 listeners will now be called in the same $digest, instead of triggering 10 separate $digest.
Angular 1.3 is required and the listeners are called in a slightly different way (though it makes no difference 99.9% of the time) It can be debated as whether this is a semver API change. Recommand to version it in 2.0.0