Skip to content

Refactoring and bug fixes#8

Merged
knonomura merged 5 commits intogriddb:masterfrom
mochizk:improve
May 30, 2019
Merged

Refactoring and bug fixes#8
knonomura merged 5 commits intogriddb:masterfrom
mochizk:improve

Conversation

@mochizk
Copy link
Copy Markdown
Contributor

@mochizk mochizk commented May 27, 2019

This pull request includes refactoring and bug fixes similar to griddb/nodejs_client#11

Refactoring :

  • Use new instead of malloc
  • Use exceptions where it makes code more simple
  • Remove preprocessor condition for support of older version like #if GS_COMPATIBILITY_SUPPORT_3_5

Bug fix :

  • Fix memory leak
  • Add missing error handling

@knonomura
Copy link
Copy Markdown
Member

Thank you for your PR to go_client.
I'll check it.

@knonomura
Copy link
Copy Markdown
Member

I understand it is similar with griddb/nodejs_client#11
I merge it.

@knonomura knonomura merged commit 6a45d27 into griddb:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants