Refactoring and bug fixes#11
Merged
knonomura merged 6 commits intogriddb:masterfrom Apr 25, 2019
Merged
Conversation
Member
|
That's excellent. |
Member
|
Sorry for late reply. I checked your source code. I understand your modification includes mainly improvement for memory management and error handling, As there are some old source code, I will update them later. Let me confirm one thing. |
Contributor
Author
|
Thank you for checking the code.
Yes, it is correct. I overlooked it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors code base and fix some bugs.
Refactoring :
#if GS_COMPATIBILITY_SUPPORT_3_5Bug fix :