Reflect source code from Nodejs client version 0.8.4#13
Merged
knonomura merged 7 commits intogriddb:masterfrom Jun 28, 2019
dangtrungtin:master
Merged
Reflect source code from Nodejs client version 0.8.4#13knonomura merged 7 commits intogriddb:masterfrom dangtrungtin:master
knonomura merged 7 commits intogriddb:masterfrom
dangtrungtin:master
Conversation
Contributor
dangtrungtin
commented
Jun 26, 2019
dangtrungtin
commented
- Merge src of Nodejs cpp from Github release 0.8.4
- Fix missing free for some abnormal cases
- Change malloc/free to new/delete with try catch
- Cut GS_COMPATIBILITY_SUPPORT_3_5 and GS_COMPATIBILITY_SUPPORT_1_5
- Fix logic defect of get data
- Update Makefile with Field.cpp and Util.cpp
- Update griddb.i to use Util and TimestampUtils
Member
|
Thank you for your PR. |
Member
|
That's great! My understanding is that your PR is similar with griddb/nodejs_client#11 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.