GG-26127: Fix GMC agent sql metadata export.#754
Merged
somjik-api merged 8 commits intomasterfrom Dec 23, 2019
Merged
Conversation
akuznetsov-gridgain
suggested changes
Dec 2, 2019
...nagement-console-agent/src/main/java/org/apache/ignite/agent/dto/cache/CacheSqlMetadata.java
Outdated
Show resolved
Hide resolved
...ent-console-agent/src/main/java/org/apache/ignite/agent/processor/CacheChangesProcessor.java
Show resolved
Hide resolved
akuznetsov-gridgain
suggested changes
Dec 3, 2019
| typeName.equals(that.typeName) && | ||
| Objects.equals(keyCls, that.keyCls) && | ||
| Objects.equals(valCls, that.valCls) && | ||
| Objects.equals(fields, that.fields) && |
Contributor
There was a problem hiding this comment.
createdBySql is not checked in equals and hashCode - is this expected?
Contributor
Author
There was a problem hiding this comment.
createdBySql available only in CacheInfo, not in CacheSqlMetadata
nva
requested changes
Dec 4, 2019
| private IgniteUuid deploymentId; | ||
|
|
||
| /** Created by sql. */ | ||
| private boolean createdBySql; |
Contributor
There was a problem hiding this comment.
Why this flag has different name in compare to ignite-core?
Contributor
Author
There was a problem hiding this comment.
The core name will only confuses us, because initially I thought that sql flag mean availability of sql queries for this cache.
nva
approved these changes
Dec 5, 2019
akuznetsov-gridgain
approved these changes
Dec 5, 2019
somjik-api
pushed a commit
that referenced
this pull request
Dec 23, 2019
(cherry picked from commit 7a47330)
somjik-api
pushed a commit
that referenced
this pull request
Dec 23, 2019
(cherry picked from commit 7a47330)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.