Document the evolving Windows SmartScreen errors#541
Merged
sdglitched merged 1 commit intomainfrom Apr 25, 2026
Merged
Conversation
Reviewer's GuideDocuments recurring Windows SmartScreen false positives for the Nuitka-built executables and explains how users can safely bypass these warnings and verify the build integrity. Flow diagram for bypassing Windows SmartScreen warningflowchart TD
A[User launches Nuitka-built executable] --> B[Windows SmartScreen warning appears]
B --> C{Does user trust the application?}
C -->|No| D[User cancels execution]
D --> E[Application does not run]
C -->|Yes, after reading documentation| F[User clicks More Info]
F --> G[User clicks Run anyway]
G --> H[Executable runs successfully]
H --> I[User can optionally verify integrity by building from source or reviewing CI builds]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The new SmartScreen section contains a small grammar issue in the sentence starting with “Not only are the executable binaries are transparently built…” – drop the second “are” and consider simplifying the sentence for clarity.
- The wording around SmartScreen (e.g., “false positives,” “untruthful detections,” “frivolous warnings”) is somewhat loaded; consider rephrasing more neutrally and focusing on explaining the cause (no code signing) and mitigation steps to keep the tone professional and clear for security‑conscious users.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new SmartScreen section contains a small grammar issue in the sentence starting with “Not only are the executable binaries are transparently built…” – drop the second “are” and consider simplifying the sentence for clarity.
- The wording around SmartScreen (e.g., “false positives,” “untruthful detections,” “frivolous warnings”) is somewhat loaded; consider rephrasing more neutrally and focusing on explaining the cause (no code signing) and mitigation steps to keep the tone professional and clear for security‑conscious users.
## Individual Comments
### Comment 1
<location path="README.md" line_range="212-215" />
<code_context>
+and open source software, we cannot afford to make additional expenses to
+subscribe to various
+[code signing](https://en.wikipedia.org/wiki/Code_signing) services. Not only
+are the executable binaries are transparently built on
+[GitHub Actions](https://github.com/gridhead/gi-loadouts/actions), folks are
+invited to verify the project's integrity by compiling things locally.
</code_context>
<issue_to_address>
**issue (typo):** Duplicate "are" in this sentence makes it grammatically incorrect.
The phrase "are the executable binaries are transparently built" has an extra "are". For example, you could write "Not only are the executable binaries transparently built on" or "Not only are the executable binaries built transparently on".
```suggestion
[code signing](https://en.wikipedia.org/wiki/Code_signing) services. Not only
are the executable binaries transparently built on
[GitHub Actions](https://github.com/gridhead/gi-loadouts/actions), folks are
invited to verify the project's integrity by compiling things locally.
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a "Warning" section to the README to address Microsoft SmartScreen false positives caused by the transition to Nuitka and the absence of code signing. The review feedback suggests improving the professional tone by replacing "untruthful" with "inaccurate" and correcting a grammatical error involving a "not only... but also" structure and a repeated word.
| [Nuitka](https://nuitka.net/) for building application executable binaries, | ||
| we have noticed frequent | ||
| [Microsoft SmartScreen](https://en.wikipedia.org/wiki/Microsoft_SmartScreen) | ||
| errors. These are false positives and untruthful detections only because the |
There was a problem hiding this comment.
The term 'untruthful' is generally used to describe human behavior. For software detections, 'inaccurate' or 'erroneous' is more appropriate and professional.
Suggested change
| errors. These are false positives and untruthful detections only because the | |
| errors. These are false positives and inaccurate detections only because the |
Comment on lines
+212
to
+215
| [code signing](https://en.wikipedia.org/wiki/Code_signing) services. Not only | ||
| are the executable binaries are transparently built on | ||
| [GitHub Actions](https://github.com/gridhead/gi-loadouts/actions), folks are | ||
| invited to verify the project's integrity by compiling things locally. |
There was a problem hiding this comment.
This sentence contains a grammatical error (the word 'are' is repeated) and is missing the 'but also' conjunction required to complete the 'not only' correlative structure.
Suggested change
| [code signing](https://en.wikipedia.org/wiki/Code_signing) services. Not only | |
| are the executable binaries are transparently built on | |
| [GitHub Actions](https://github.com/gridhead/gi-loadouts/actions), folks are | |
| invited to verify the project's integrity by compiling things locally. | |
| [code signing](https://en.wikipedia.org/wiki/Code_signing) services. Not only | |
| are the executable binaries transparently built on | |
| [GitHub Actions](https://github.com/gridhead/gi-loadouts/actions), but folks are | |
| also invited to verify the project's integrity by compiling things locally. |
gridhead
force-pushed
the
sign
branch
2 times, most recently
from
d501245 to
3b0bbb7
Compare
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the evolving Windows SmartScreen errors
Fixes #540
Summary by Sourcery
Documentation: