-
-
Notifications
You must be signed in to change notification settings - Fork 6
Document the evolving Windows SmartScreen errors #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -194,6 +194,26 @@ ensure that the Tesseract OCR application is installed and configured properly. | |||||||||||||||||
|
|
||||||||||||||||||
| **Releases** that _automatically update_ can be found [here](https://pypi.org/project/gi-loadouts/). | ||||||||||||||||||
|
|
||||||||||||||||||
| ### Warning | ||||||||||||||||||
|
|
||||||||||||||||||
| Since we moved from [PyInstaller](https://www.pyinstaller.org/) to | ||||||||||||||||||
| [Nuitka](https://nuitka.net/) for building application executable binaries, | ||||||||||||||||||
| we have noticed frequent | ||||||||||||||||||
| [Microsoft SmartScreen](https://en.wikipedia.org/wiki/Microsoft_SmartScreen) | ||||||||||||||||||
| errors on Microsoft Windows. These false positive appear only because the | ||||||||||||||||||
| executable binaries are not code signed. The protection system flags them as | ||||||||||||||||||
| potentially unsafe due to the absence of an active code signing certificate, | ||||||||||||||||||
| but that does not mean that the codebase is malicious. | ||||||||||||||||||
|
|
||||||||||||||||||
| To proceed past these frivolous warnings, simply click on **"More Info"** and | ||||||||||||||||||
| then **"Run anyway"** to start the executable binary. As this project is free | ||||||||||||||||||
| and open source software, we cannot afford to make additional expenses to | ||||||||||||||||||
| subscribe to various | ||||||||||||||||||
| [code signing](https://en.wikipedia.org/wiki/Code_signing) services. Not only | ||||||||||||||||||
| are the executable binaries transparently built on | ||||||||||||||||||
| [GitHub Actions](https://github.com/gridhead/gi-loadouts/actions), but folks are | ||||||||||||||||||
| invited to verify the project's integrity by compiling things locally. | ||||||||||||||||||
|
Comment on lines
+212
to
+215
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This sentence contains a grammatical error (the word 'are' is repeated) and is missing the 'but also' conjunction required to complete the 'not only' correlative structure.
Suggested change
|
||||||||||||||||||
|
|
||||||||||||||||||
| ## Usage | ||||||||||||||||||
|
|
||||||||||||||||||
| 1. Select the [*vision*](https://genshin-impact.fandom.com/wiki/Vision) from | ||||||||||||||||||
|
|
||||||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.