Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,26 @@ ensure that the Tesseract OCR application is installed and configured properly.

**Releases** that _automatically update_ can be found [here](https://pypi.org/project/gi-loadouts/).

### Warning

Since we moved from [PyInstaller](https://www.pyinstaller.org/) to
[Nuitka](https://nuitka.net/) for building application executable binaries,
we have noticed frequent
[Microsoft SmartScreen](https://en.wikipedia.org/wiki/Microsoft_SmartScreen)
errors on Microsoft Windows. These false positive appear only because the
executable binaries are not code signed. The protection system flags them as
potentially unsafe due to the absence of an active code signing certificate,
but that does not mean that the codebase is malicious.

To proceed past these frivolous warnings, simply click on **"More Info"** and
then **"Run anyway"** to start the executable binary. As this project is free
and open source software, we cannot afford to make additional expenses to
subscribe to various
[code signing](https://en.wikipedia.org/wiki/Code_signing) services. Not only
are the executable binaries transparently built on
[GitHub Actions](https://github.com/gridhead/gi-loadouts/actions), but folks are
invited to verify the project's integrity by compiling things locally.
Comment thread
sourcery-ai[bot] marked this conversation as resolved.
Comment on lines +212 to +215
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This sentence contains a grammatical error (the word 'are' is repeated) and is missing the 'but also' conjunction required to complete the 'not only' correlative structure.

Suggested change
[code signing](https://en.wikipedia.org/wiki/Code_signing) services. Not only
are the executable binaries are transparently built on
[GitHub Actions](https://github.com/gridhead/gi-loadouts/actions), folks are
invited to verify the project's integrity by compiling things locally.
[code signing](https://en.wikipedia.org/wiki/Code_signing) services. Not only
are the executable binaries transparently built on
[GitHub Actions](https://github.com/gridhead/gi-loadouts/actions), but folks are
also invited to verify the project's integrity by compiling things locally.


## Usage

1. Select the [*vision*](https://genshin-impact.fandom.com/wiki/Vision) from
Expand Down