Update gridstack.jQueryUI.js #1412
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to fix error mentioned in this thread: #858 Draggable/resizable should be initialized by this point anyways if you should be able to set options for them
adumesny
reviewed
Oct 17, 2020
| el = $(el); | ||
| if (opts === 'disable' || opts === 'enable' || opts === 'destroy') { | ||
| el.resizable(opts); | ||
| el.resizable().resizable(opts); |
Member
There was a problem hiding this comment.
thank you for the fix! but it has the side effect of enabling resizable before destroying it, which is wasteful if it wasn't created to start with. looking to see if we can avoid this...
Member
|
actually you are looking at an old code base... in 2.0 (typescript) you can see in https://github.com/gridstack/gridstack.js/blob/develop/src/jq/gridstack-dd-jqueryui.ts#L32 } else if (opts === 'destroy') {
if ($el.data('ui-draggable')) { // error to call destroy if not there
$el.draggable(opts);
}so no need for your fix. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change to fix error mentioned in this thread: #858