Skip to content

Update gridstack.jQueryUI.js #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 1 commit into from
Closed

Update gridstack.jQueryUI.js #1412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/gridstack.jQueryUI.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
JQueryUIGridStackDragDropPlugin.prototype.resizable = function(el, opts) {
el = $(el);
if (opts === 'disable' || opts === 'enable' || opts === 'destroy') {
el.resizable(opts);
el.resizable().resizable(opts);
Copy link
Member

@adumesny adumesny Oct 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the fix! but it has the side effect of enabling resizable before destroying it, which is wasteful if it wasn't created to start with. looking to see if we can avoid this...

} else if (opts === 'option') {
var key = arguments[2];
var value = arguments[3];
Expand All @@ -53,7 +53,7 @@
JQueryUIGridStackDragDropPlugin.prototype.draggable = function(el, opts) {
el = $(el);
if (opts === 'disable' || opts === 'enable' || opts === 'destroy') {
el.draggable(opts);
el.draggable().draggable(opts);
} else {
el.draggable($.extend({}, this.grid.opts.draggable, {
containment: (this.grid.opts.isNested && !this.grid.opts.dragOut) ?
Expand Down