Fixed unhandled exception happening in _mouseMove handler #2525
Conversation
…, 'this.el' is undefined. Happens if element is removed just before call of _mouseMove and just after _mouseDown.
jemunk
changed the title
| if (this.dragTimeout) window.clearTimeout(this.dragTimeout); | ||
| delete this.dragTimeout; | ||
| if (this.dragging) this._mouseUp(this.mouseDownEvent); | ||
| if (this.mouseDownEvent) this._mouseUp(this.mouseDownEvent); |
There was a problem hiding this comment.
this seems ok, but I would really like to know why would you remove the element after mouse down, but before a move+up behavior ? Also I need to look at why we only wanted to call up if we moved >3 pixels instead of always...
There was a problem hiding this comment.
I my case it is being removed from a configuration. A DB change makes the element remove.
So if a user starts dragging in that moment, it is possible for it being removed just between the press and move handlers.
But the _mouseUp method seems to take fully care of all cleaning up. So it is just a matter of the destroy method doing it right.
There was a problem hiding this comment.
looked at code and you are correct. _mouseUp() handles this.dragging separately so it should ways be called if down. thanks.
2 participants
Description
Fixed unhandled exception happening in _mouseMove handler on line 209, 'this.el' is undefined. Happens if element is removed just before call of _mouseMove and just after _mouseDown.
Checklist
yarn test)I am unable to run yarn test. Gets all kinds of strange errors.
I had a setup easily reproducing the issue. After the fix, I could not reproduce it anymore.