Skip to content

Fixed unhandled exception happening in _mouseMove handler #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adumesny merged 1 commit into from
Nov 5, 2023
Merged

Fixed unhandled exception happening in _mouseMove handler #2525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dd-draggable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export class DDDraggable extends DDBaseImplement implements HTMLElementExtendOpt
public destroy(): void {
if (this.dragTimeout) window.clearTimeout(this.dragTimeout);
delete this.dragTimeout;
if (this.dragging) this._mouseUp(this.mouseDownEvent);
if (this.mouseDownEvent) this._mouseUp(this.mouseDownEvent);
Copy link
Member

@adumesny adumesny Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems ok, but I would really like to know why would you remove the element after mouse down, but before a move+up behavior ? Also I need to look at why we only wanted to call up if we moved >3 pixels instead of always...

Copy link
Author

@jemunk jemunk Nov 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I my case it is being removed from a configuration. A DB change makes the element remove.
So if a user starts dragging in that moment, it is possible for it being removed just between the press and move handlers.
But the _mouseUp method seems to take fully care of all cleaning up. So it is just a matter of the destroy method doing it right.

Copy link
Member

@adumesny adumesny Nov 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked at code and you are correct. _mouseUp() handles this.dragging separately so it should ways be called if down. thanks.

this.disable(true);
delete this.el;
delete this.helper;
Expand Down