Angular wrapper using component+props (instead of selector+input)#3310
Merged
Conversation
**Breaking changes: Angular wrapper only** (`gridstack/dist/angular`)
Widget JSON fields are renamed to match the React/Vue convention, making layouts portable across all three frameworks:
```diff
- { selector: 'app-chart', input: { title: 'Revenue' } }
+ { component: 'app-chart', props: { title: 'Revenue' } }
```
The registration call is also renamed:
```diff
- GridstackComponent.addComponentToSelectorType([ChartComponent, TableComponent]);
+ GridstackComponent.registerComponents([ChartComponent, TableComponent]);
```
The static map and its type are renamed accordingly (`selectorToType` → `componentMap`, `SelectorToType` → `ComponentMap`). If you subclass `BaseWidget` and override `deserialize()`, replace any direct reads of `w.input` with `w.props`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes: Angular wrapper only (
gridstack/dist/angular)Widget JSON fields are renamed to match the React/Vue convention, making layouts portable across all three frameworks:
The registration call is also renamed:
The static map and its type are renamed accordingly (
selectorToType→componentMap,SelectorToType→ComponentMap). If you subclassBaseWidgetand overridedeserialize(), replace any direct reads ofw.inputwithw.props.Description
Please explain the changes you made here. Include an example of what your changes fix or how to use the changes.
Checklist
yarn test)