check voltageRegulatorOn for battery modification - #214
Merged
Conversation
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesBattery voltage regulation validation
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/org/gridsuite/modification/modifications/BatteryModification.java`:
- Line 142: Update the voltage-regulation validation condition in
BatteryModification so a null value from voltageRegulationOn.getValue() cannot
be auto-unboxed; treat only Boolean.TRUE as enabled, while preserving the
existing validation behavior for false or absent values.
In
`@src/test/java/org/gridsuite/modification/modifications/BatteryModificationTest.java`:
- Around line 97-119: Extend BatteryModificationTest beside the existing NaN
targetV cases with a test using targetV(new AttributeModification<>(null,
OperationType.SET)) while voltageRegulationOn is enabled. Invoke check through
the resulting BatteryModification, assert NetworkModificationException, and
verify the expected null target-voltage validation message.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 419fd7e3-dd6d-4252-86ec-c9ee42f62ab6
📒 Files selected for processing (2)
src/main/java/org/gridsuite/modification/modifications/BatteryModification.javasrc/test/java/org/gridsuite/modification/modifications/BatteryModificationTest.java
Comment on lines
+97
to
+119
| // check if battery has NaN targetV then it throws an error if voltageRegulator is set to On | ||
| VoltageRegulation voltageRegulation = network.getBattery("v3Battery").getExtension(VoltageRegulation.class); | ||
| voltageRegulation.setTargetV(Double.NaN); | ||
| BatteryModificationInfos batteryModificationInfos6 = BatteryModificationInfos.builder() | ||
| .equipmentId("v3Battery") | ||
| .voltageRegulationOn(new AttributeModification<>(true, OperationType.SET)) | ||
| .build(); | ||
| BatteryModification generatorModification6 = (BatteryModification) batteryModificationInfos6.toModification(); | ||
| message = assertThrows(NetworkModificationException.class, | ||
| () -> generatorModification6.check(network)).getMessage(); | ||
| assertEquals("MODIFY_BATTERY_ERROR : 'v3Battery': voltage setpoint value (NaN) is invalid (voltage regulator is on)", message); | ||
|
|
||
| // check if battery targetV is set to NaN then it throws an error if voltageRegulator is set to On | ||
| voltageRegulation.setTargetV(400.0); | ||
| BatteryModificationInfos batteryModificationInfos7 = BatteryModificationInfos.builder() | ||
| .equipmentId("v3Battery") | ||
| .targetV(new AttributeModification<>(Double.NaN, OperationType.SET)) | ||
| .voltageRegulationOn(new AttributeModification<>(true, OperationType.SET)) | ||
| .build(); | ||
| BatteryModification generatorModification7 = (BatteryModification) batteryModificationInfos7.toModification(); | ||
| message = assertThrows(NetworkModificationException.class, | ||
| () -> generatorModification7.check(network)).getMessage(); | ||
| assertEquals("MODIFY_BATTERY_ERROR : 'v3Battery': voltage setpoint value (NaN) is invalid (voltage regulator is on)", message); |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add coverage for a null requested target voltage.
The tests cover NaN, but they do not cover targetV with a null value. Add a case with targetV(new AttributeModification<>(null, OperationType.SET)) and enabled voltage regulation. This verifies the null-validation branch.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@src/test/java/org/gridsuite/modification/modifications/BatteryModificationTest.java`
around lines 97 - 119, Extend BatteryModificationTest beside the existing NaN
targetV cases with a test using targetV(new AttributeModification<>(null,
OperationType.SET)) while voltageRegulationOn is enabled. Invoke check through
the resulting BatteryModification, assert NetworkModificationException, and
verify the expected null target-voltage validation message.
|
etiennehomer
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary