#20178: Added Dell and Lenovo to warranty link function - #12669
Merged
Conversation
|
This pull request has been linked to Shortcut Story #20178: Add Dell and Lenovo to Warranty links. |
|
snipe
requested changes
Mar 20, 2023
| </a> | ||
| @elseif ((strtolower($asset->model->manufacturer->name) == "lenovo") || (str_starts_with(str_replace(' ','',strtolower($asset->model->manufacturer->name)),"lenovoinc"))) | ||
| <a href="https://pcsupport.lenovo.com/us/en/warrantylookup#/" target="_blank"> | ||
| <img src="/img/demo/manufacturers/lenovoicon.png" style="width:25px;height:25px;"><span class="sr-only">Lenovo Warranty Status Lookup</span></i> |
Member
There was a problem hiding this comment.
Can I get this sr-only text translated (including the one above that I made for Apple).
Something like 'general.warranty_lookup_mfg' => ':manufacturer Warranty Status Lookup',
Member
|
Love it, thank you! |
2 tasks
Contributor
Author
Sorry for the delay, I did consider HP, but are instead working on a dynamic way for any manufacturer to have this functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An extension of #12477
Dell and Lenovo were added to the list of manufacturers that pop a link to the warranty checker page.
The attemped functionality to insert the serial number upon creating the link was removed, as the links are too complicated and any change to the websites themselves will end up defaulting to the main warranty page. Therefore, to reduce bloat and create a predictable experience, the links go to each manufacturer's respected checker page.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested locally
Checklist: