feat(presence): send own proxy id with logout - #31
Merged
Conversation
Scopes the session delete to this proxy: a disconnect that raced a proxy-to-proxy transfer must not remove the session the next proxy just created (service-player honours the new field, empty keeps the old unconditional delete). Contracts bump to 0.7.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the proxy drain project. The disconnect fired when a player is transferred to another proxy races that proxy's login — an unscoped logout could delete the session the next proxy just created. Both logout paths (disconnect, abandoned-login release) now carry
PROXY_ID; service-player then only deletes while the session still belongs to this proxy.Depends on groundsgg/library-grpc-contracts#78 → player 0.7.0 (pinned here) — CI stays red until that release exists.