Skip to content

fix: remove Stripe placeholder secret defaults; reconcile stale audit docs - #1367

Merged
groupthinking merged 3 commits into
mainfrom
addressing-issues-grv-194-a1c2
Aug 29, 2026
Merged

fix: remove Stripe placeholder secret defaults; reconcile stale audit docs#1367
groupthinking merged 3 commits into
mainfrom
addressing-issues-grv-194-a1c2

Conversation

@groupthinking

Copy link
Copy Markdown
Owner

Canonical issue

Closes #1126

Outcome

The .env.example generator no longer emits placeholder-looking secrets (sk_test_..., pk_test_..., whsec_...) when Stripe keys are absent — it emits empty values, matching _generate_env_local. The Dec-2025 audit docs no longer misreport resolved findings as open: each carries a dated resolution-status banner with code evidence, and the readiness verdict moves from the stale 57.5/100 🔴 NO-GO to 73/100 🟡 CONDITIONAL (security cleared; operational gaps remain).

Scope

  • Included: Stripe default fix in ai_code_generator.py; resolution-status banners in docs/analysis/{SECURITY_REPORT,REMEDIATION_PLAN,EXECUTIVE_SUMMARY,PRODUCTION_CHECKLIST}.md; supersession note in docs/NPM_VULNERABILITIES.md; stale CHANGELOG follow-up note corrected.
  • Explicitly excluded: re-remediating already-fixed findings (pickle, subprocess, XSS, devalue/next chain — all verified fixed in current code); fixing the 4 new unrelated npm audit advisories (ip-address, postcss — noted in docs, fixable via npm audit fix); CI coverage config (already enforced via fail_under = 88.1833 in pyproject.toml + coverage.yml).

Risk

  • Risk level: low
  • Failure mode: generated .env.example now has empty Stripe values instead of placeholders when env keys are unset.
  • Rollback: revert the two commits.

Verification

  • Focused tests: pytest tests/unit/test_ai_code_generator.py — 253 passed
  • Every doc claim re-verified against current code (no pickle imports in src/youtube_extension/, no frontend/ dir or dangerouslySetInnerHTML, list-form subprocess calls, devalue absent from lockfile, next resolves 16.2.12, npm audit re-run to scope SEC-002 accurately)
  • Required CI

Production evidence

Not applicable — code path only affects generated .env.example scaffolding; remaining changes are documentation.

Agent handoff

  • One canonical issue is linked
  • No competing PR implements the same issue
  • Acceptance criteria are satisfied
  • Required checks pass on the current head
  • Human decision is requested only for product, security, irreversible infrastructure, or production approval

groupthinking and others added 2 commits August 4, 2026 06:11
… docs

The env-example generator in ai_code_generator.py defaulted missing Stripe
keys to placeholder-looking secrets (sk_test_..., pk_test_..., whsec_...);
it now emits empty values, matching _generate_env_local.

The Dec-2025 audit docs (SECURITY_REPORT, REMEDIATION_PLAN,
EXECUTIVE_SUMMARY, PRODUCTION_CHECKLIST, NPM_VULNERABILITIES) still reported
SEC-001..005 as open and a 57.5/100 NO-GO verdict, though re-verification
against current code shows all of them resolved. Each doc now carries a
dated resolution-status banner with code evidence, and the checklist
verdict is re-scored to 73/100 CONDITIONAL (security cleared; operational
gaps remain). Also corrects the stale CHANGELOG note about duplicate
redirects()/headers() in apps/web/next.config.js.

Generated with [Linear](https://linear.app/myxstack/issue/GRV-194/addressing-issues#agent-session-ea8ca5b2)

Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
npm audit currently reports 4 new unrelated advisories (ip-address,
postcss), so the docs now distinguish "original devalue/next chain
resolved" from "audit clean", and the Dependencies gate is CONDITIONAL.

Generated with [Linear](https://linear.app/myxstack/issue/GRV-194/addressing-issues#agent-session-ea8ca5b2)

Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
@linear-code

linear-code Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

GRV-194

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
v0-uvai Ready Ready Preview, v0 Aug 29, 2026 7:53am

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 83d4c895-e4f4-4d44-b720-acee7c519e79


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA ec6a23d.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@github-actions github-actions Bot added documentation Improvements or additions to documentation python labels Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Agent Completion Truth Gate: BLOCKED

Reasons: invalid_payload

Machine-readable verdict
{
  "details": {
    "collection_errors": [
      "incomplete_linked_issue_contract",
      "missing_intent_snapshot",
      "missing_agent_run_id",
      "missing_agent_login"
    ],
    "invalid_fields": [
      "policy.agent_login",
      "policy.run_id"
    ]
  },
  "reasons": [
    "invalid_payload"
  ],
  "verdict": "blocked"
}

Workflow evidence

@groupthinking groupthinking self-assigned this Aug 13, 2026
@groupthinking
groupthinking marked this pull request as ready for review August 29, 2026 07:09
@groupthinking
groupthinking merged commit 6a1303c into main Aug 29, 2026
21 of 27 checks passed
@groupthinking
groupthinking deleted the addressing-issues-grv-194-a1c2 branch August 29, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Addressing Issues

1 participant