build(deps-dev): bump js-yaml from 4.3.0 to 4.3.1 - #1433
Conversation
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.3.0 to 4.3.1. - [Changelog](https://github.com/nodeca/js-yaml/blob/4.3.1/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.3.0...4.3.1) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.3.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files
|
|
groupthinking
left a comment
There was a problem hiding this comment.
Review — no objection on the merits; blocked only by an unsatisfiable gate
Reviewed at head dff2ba6. Both hunks check out. The one thing standing between this and merge is a required check Dependabot has no way to pass.
The bump itself
- Integrity hash verified against the registry, not taken from the PR body.
registry.npmjs.org/js-yaml/4.3.1returnssha512-CY6crGq313MX8GkwvB7tzgp99vjQxY1++5y10/BKN/GUfHqWaOGQMNZkBvqSzsZKWk/ijwHlWzzkLulsGHhjWQ==— byte-identical to the lockfile entry. - Patch release, single upstream commit (
c3cc4b0), no API surface change.
Exposure is narrower than the "Security" label suggests
Worth recording so this isn't treated as urgent:
js-yamlis not declared in anypackage.jsonin the repo — it is transitive only.- No source file imports it: no
from 'js-yaml'/require('js-yaml')anywhere in*.ts,*.tsx,*.js,*.mjs. - The lock entry carries
"dev": true, so it never reaches a production bundle.
The upstream fix removes quadratic complexity from !!omap duplicate-key detection. Reaching it requires parsing untrusted YAML containing !!omap, at build/test time only. Low urgency — but the patch is a strict improvement at zero cost, so there's no reason not to take it.
The second hunk is a stale-lock correction, not drift
The diff also moves tailwindcss ^4.3.2 → ^4.3.3 in the apps/web devDependencies mirror. That looks like unrelated drift and is not — it's the lockfile catching up to the manifest:
| File | tailwindcss range |
|---|---|
apps/web/package.json @ main |
^4.3.3 |
apps/web/package.json @ this branch |
^4.3.3 (untouched) |
package-lock.json @ main |
^4.3.2 ← stale |
No package.json is modified by this PR (git diff --stat = package-lock.json only), and no resolved tailwindcss version changes — only the recorded range. npm install corrected a desync that already existed on main.
Flagging one consequence: #1381 explicitly reverted this same correction "to keep this PR surgical," which is why main is still out of sync. Reverting it again here would just preserve the desync. Recommend letting it land.
Sole blocker
PR Governance and Canonical issue and evidence are red. Everything else — 22 of 24 checks — is green.
The failure text is:
## Canonical issue is missing …; ## Outcome is missing …; ## Risk is missing …; ## Verification is missing …; ## Production evidence is missing …; exactly one closing reference is required: Closes #<issue>
Dependabot composes its body from a fixed template and cannot emit those five headings or a Closes #<issue> reference. This is not a bar it failed — it's one it has no mechanism to clear, so no amount of rebasing or recreating this PR will turn it green.
#1423 fixes exactly this: it returns neutral for dependabot[bot] (not success — the contract is inapplicable, not satisfied), with behavioural tests asserting a human author with the same body still fails. It is currently in draft. Merging it is the prerequisite for this PR and for #1171.
Recommendation
Merge #1423 first, then this one. No changes requested here.
Generated by Claude Code
Blocker cleared —
|
| Check | Before (dff2ba6) |
After (d6c91a4) |
|---|---|---|
Canonical issue and evidence |
❌ failure | ✅ success |
PR Governance |
❌ failure | ⚪ neutral |
PR Governance publishing neutral rather than success is the correct outcome, not a near-miss — #1423 deliberately distinguishes not applicable from satisfied, so the check does not launder an exemption as enforcement. That was the design intent and it held.
Remaining checks are the routine matrix (build, test, lint-*, trivy, npm-audit, Security Scan - javascript, coverage) — all queued or in progress at time of writing, none failing. Already green on this head: validate, guards, bandit, python-safety, gitleaks, dependency-review, Vercel.
Disposition
Moves from HALTED(ci_failing) to HALTED(awaiting_merge_approval) — no longer blocked on anything an agent can fix, and no longer blocked on a second PR.
Still not merging: main is protected, there is no automerge label, and MERGE_POLICY.md adoption step 6 (Enable Class A auto-merge) has not shipped. The change itself is js-yaml 4.3.0 → 4.3.1, a dev-dependency patch confined to package-lock.json — Class A, with dependency-review reporting no vulnerability, license, or Scorecard issues.
gh pr checks 1433 --watch # confirm the remaining matrix goes green
gh pr merge 1433 --squashWorth noting the durable win: this gate was unsatisfiable for every Dependabot PR, not just this one. #1459 (hono 4.12.32 → 4.13.1) opened after #1423 landed and is not hitting it.
Generated by Claude Code
Bumps js-yaml from 4.3.0 to 4.3.1.
Changelog
Sourced from js-yaml's changelog.
Commits
86e91b84.3.1 releasedc3cc4b0Backport quadratic complexity fix for !!omapDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.