328 expose secondary identities - #329
Merged
Merged
Conversation
field-set back to the vertex primary identity. Add
Connection.resolve_vertices with a generic implementation built on
fetch_docs + FilterExpression, so every backend is covered, plus a
TigerGraph override using an interpreted GSQL query (REST++ filters are
conjunction-only and cannot express a batched OR).
Unlike fetch_present_documents, every match is returned rather than the
first: the caller's ambiguity policy needs the count, not a sample.
Also fixes three defects this path depends on:
- postgres fetch_docs ignored filters and return_keys, returning the
whole table for any query.
- graflo_backend fetch_docs ignored filters and could not read back
buffered writes (no INDEX.json), so it was not read-your-writes.
- FilterExpression did not parenthesize nested composites for AQL/nGQL/
GSQL, so AND[OR[a,b],c] silently rendered as a OR (b AND c); and PYTHON
evaluation only handled dunder-authored leaves, so a list-form filter
evaluated to False while rendering correctly everywhere else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.