core: DelayedClientCall should include context in error - #12884
Merged
Conversation
If the RPC is able to continue in time it can proceed to ClientCallImpl, which will describe the delay as coming from name resolution. But if it fails before then the message didn't give any hint what gRPC was waiting on. As noticed during b/526868988.
shivaspeaks
approved these changes
Jun 30, 2026
shivaspeaks
left a comment
shivaspeaks
left a comment
Member
There was a problem hiding this comment.
DataPlaneDelayedCall class needs to be adjusted since it extends and call super.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the RPC is able to continue in time it can proceed to ClientCallImpl, which will describe the delay as coming from name resolution. But if it fails before then the message didn't give any hint what gRPC was waiting on.
As noticed during b/526868988.
CC @kannanjgithub