-
Notifications
You must be signed in to change notification settings - Fork 4k
Allow skip codegen build #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2621589 to
8df680e
Compare
|
It seems like project properties are exposed as |
|
Can we only commit the grpc generated code? Is there a reason to commit the protobuf generated code? |
Nice! I have updated the PR.
Good point. I am going to update google/protobuf-gradle-plugin/pull/7 to allow specifying generated source dir for individual sourceSets so that we can keep protobuf generated code under |
|
Ah, I see. That answered my question. Having different source sets would be a little weird; it's fine as it is. I'll review this this morning. |
lib/netty
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a stray change, and will break the build. You likely didn't do a "git submodule update" and then did a "git commit -a". It'll be nice when we don't have to mess with the submodules...
|
Looks good. I think we just need to decide what the default setting will be. |
|
@zhangkun83, LGTM, but the netty submodule change needs to be removed. |
Resolves grpc#357 - Add project property ``grpc.skip.codegen``, which is false by default. People who don't change the codegen nor the proto files can set it to true so that they don't need to set up C++ compilation. - Check in all generated files under ``src/generated``.
27cb9a7 to
111f6dd
Compare
|
After this PR, "gradle clean" will delete the generated files that are tracked, which is annoy, do we have a solution for that? |
|
Yeah, it is a bit annoying. I've just done a |
Resolves #357
grpc.skip.codegen=trueso that they don't need to set up C++ compilation.src/generated.@ejona86 please review