Delete the generated files only before generateProto. #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously generated files were deleted at configuration time. Running non-build tasks such as ``clean`` or ``tasks`` would delete the generated files and tracked by git, which is annoying. Now we delete them only before the ``generateProto`` task, which solves the problem. After this change, the case that ``generateProto`` is not executed at all, is no longer covered. However, it is much less likely than the still-covered case that ``generateProto`` is not re-generating all files due to misconfiguration.
Member
|
@zhangkun83 LGTM. Thanks! This will be nice. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously generated files were deleted at configuration time. Running
non-build tasks such as
cleanortaskswould delete thegenerated files and tracked by git, which is annoying. Now we delete
them only before the
generatePrototask, which solves the problem.After this change, the case that
generateProtois not executed atall, is no longer covered. However, it is much less likely than the
still-covered case that
generateProtois not re-generating all filesdue to misconfiguration.
Addresses #387#issuecomment-102220365
@ejona86 please review