Add ManagedChannelBuilder/ServerBuilder.maxInboundMetadataSize#4897
Merged
Conversation
ejona86
changed the title
zpencer
approved these changes
Oct 11, 2018
| * HTTP/2's SETTINGS_MAX_HEADER_LIST_SIZE</a>. It sums the bytes from each entry's key and value, | ||
| * plus 32 bytes of overhead per entry. | ||
| */ | ||
| public NettyChannelBuilder maxInboundMetadataSize(int maxInboundMetadataSize) { |
Contributor
There was a problem hiding this comment.
nit: was the parameter supposed to be named bytes for this set of functions? For InProcess it is currently named bytes.
ejona86
force-pushed
the
maxinboundmessagesize
branch
from
bf6191b to
11fb10e
Compare
Member
Author
|
@zpencer, done. I noticed many more problems. I'll need to rebase before merging. |
Member
Author
|
@zpencer PTAL |
zpencer
approved these changes
Oct 18, 2018
ejona86
force-pushed
the
maxinboundmessagesize
branch
from
11fb10e to
3645abc
Compare
Member
Author
|
Rebased to get past conflicts. Waiting on CI and then will merge. |
This is a rename of the pre-existing Netty builder method, so aliases were added to the Netty builders. Fixes grpc#4050. This API was a minor rename to the pre-existing Netty API, so has already undergone API review and thus is not ExperimentalApi.
ejona86
force-pushed
the
maxinboundmessagesize
branch
from
3645abc to
53b0f3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support was added to InProcess and OkHttp transports. As mentioned
in #4567 OkHttp will not actually limit the memory used.
This API was a minor rename to the pre-existing Netty API,
so has already undergone API review and thus is not ExperimentalApi.
In adding transport tests I discovered Netty's behavior for trailers is
broken causing the stream to be orphaned and the client to hang. I have
verified this is fixed by netty/netty#8332 .
The commits will remain separate when merging. They may help during
review, but probably aren't too necessary.
Fixes #4050 and #4567.
CC @garrettjonesgoogle