core: finalize convenient overrides on LoadBalancer.Helper and Subchannel.#4954
Merged
Merged
Conversation
…nnel. Those overrides are kept for backward compatibility and convenience for callers. Documentation already says implementations should not override them. Making them final reduces confusion around which override should be verified in tests and be overridden in forwarding classes, thus prevents bugs caused by such confusion.
ejona86
approved these changes
Oct 16, 2018
| * <p>The LoadBalancer is responsible for closing unused Subchannels, and closing all | ||
| * Subchannels within {@link #shutdown}. | ||
| * | ||
| * <p>The default implementation calls {@link #createSubchannel(List, Attributes)}. |
Member
There was a problem hiding this comment.
Should we still specify that this method calls the other method?
Contributor
Author
There was a problem hiding this comment.
Sure. I have change the javadoc to refer to the other method.
ejona86
approved these changes
Oct 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those overrides are kept for backward compatibility and convenience
for callers. Documentation already says implementations should not
override them. Making them final reduces confusion around which
override should be verified in tests and be overridden in forwarding
classes, thus prevents bugs caused by such confusion.