Fix object lifetime and memory management problems in server code#248
Merged
murgatroid99 merged 4 commits intogrpc:masterfrom Apr 3, 2018
Merged
Conversation
nicolasnoble
approved these changes
Apr 2, 2018
nicolasnoble
reviewed
Apr 2, 2018
| new grpc_ssl_pem_key_cert_pair[key_cert_pair_count]; | ||
|
|
||
| grpc_ssl_pem_key_cert_pair key_cert_pairs[key_cert_pair_count]; | ||
| StringOrNull key_strings[key_cert_pair_count]; |
Contributor
There was a problem hiding this comment.
#include <memory>
[...]
std::auto_ptr<StringOrNull> key_strings = new StringOrNull[key_cert_pair_count];
std::auto_ptr<StringOrNull> cert_strings = new StringOrNull[key_cert_pair_count];
And then later use cert_strings[i]->assign().
Contributor
|
Also, from tests: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a few fixes:
Server#tryShutdownis always called asynchronously.