Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Channel argument validation error messages #932

Merged
merged 1 commit into from Jul 8, 2019

Conversation

@clehene
Copy link
Contributor

@clehene clehene commented Jul 2, 2019

If passing an undefined as the first argument throws a generic error about all 3 arguments which is confusing. Googling for it sends you to rabbit hole (e.g. grpc/grpc#10786).

@thelinuxfoundation
Copy link

@thelinuxfoundation thelinuxfoundation commented Jul 2, 2019

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@murgatroid99
Copy link
Member

@murgatroid99 murgatroid99 commented Jul 3, 2019

Thank you for your contribution. I can't merge the PR until you sign the CLA.

@clehene
Copy link
Contributor Author

@clehene clehene commented Jul 4, 2019

@murgatroid99 signed

@murgatroid99 murgatroid99 merged commit c94d143 into grpc:master Jul 8, 2019
19 checks passed
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants