Fix 'noImplicitAny' issue with declaration file. #949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest release of grpc-node cannot be used in a typescript project that uses -noImplicitAny. This is due to a signature being added without a specified return type. This causes the return type to implicitly be 'any' which TS explicitly disallows. For projects that use strict flags to catch lots of bugs, this prevents usage of this version of grpc entirely.
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
Contributor
Author
|
This was introduced in #796. Tagging @murgatroid99 and @nicolasnoble for this regression. Thanks! |
Contributor
Author
|
Happy to help! |
Contributor
Author
|
Thanks all! |
Contributor
|
Hi, thx for this patch, has it been back ported to 1.22.x branch yet ? |
Contributor
|
Well in case not, I submitted a PR #959 |
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #950
The latest release of grpc-node cannot be used in a typescript project that uses -noImplicitAny. This is due to a signature being added without a specified return type. This causes the return type to implicitly be 'any' which TS explicitly disallows. For projects that use strict flags to catch lots of bugs, this prevents usage of this version of grpc entirely.
Fix is simple, just actually provide an annotation for this method.