Wire A32 circuit breaking into xDS channels - #2712
Open
mingley wants to merge 1 commit into
Open
Conversation
mingley
force-pushed
the
mingley/a32-circuit-breaking-wiring
branch
3 times, most recently
from
June 30, 2026 17:45
4b4f77c to
01c865f
Compare
mingley
marked this pull request as ready for review
July 30, 2026 23:00
mingley
force-pushed
the
mingley/a32-circuit-breaking-wiring
branch
from
July 31, 2026 03:39
53fe418 to
e97a6ed
Compare
YutaoMa
reviewed
Aug 6, 2026
YutaoMa
reviewed
Aug 6, 2026
Enforce CDS max_requests across xDS channels with process-wide request counters. Preserve CDS and EDS removal generations so re-added clusters cannot reuse stale limits, connectors, or endpoints.
mingley
force-pushed
the
mingley/a32-circuit-breaking-wiring
branch
from
August 7, 2026 18:47
221f221 to
8e685d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR connects gRFC A32 circuit breaking to the xDS request path in
tonic-xds. The circuit breaker works like a shared pool of slots: before an endpoint attempt begins, the channel reserves one slot for the selected{cluster, EDS service}. The CDSmax_requestsvalue sets the pool size, with the A32 default of 1024 when the field is omitted. If no slot is available, the client returns a local, non-retryable gRPCUNAVAILABLEresponse without contacting an endpoint.Testing Done
cargo fmt --all -- --check— completed successfully.cargo test -p tonic-xds client::loadbalance::loadbalancer::tests::circuit_breaker_drops_are_not_endpoint_outlier_outcomes -- --exact— 1 passed, 0 failed, 376 filtered out.