C# prevent name clashes with generated classes/enums in *Grpc.cs#10147
Merged
jtattermusch merged 2 commits intoMar 14, 2017
Conversation
Contributor
Author
Contributor
Author
|
@jskeet I will publish the prerelease packages as soon this one gets reviewed and merged (feel free to review yourself, this change should look familiar to you). |
Contributor
|
Yes, that looks very familiar, and LGTM :) |
apolcyn
approved these changes
Mar 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents name clashes between code from Grpc.Core and names in .proto files.
For example generating a
message Status {}clashes with Grpc.Core.Status class.To achieve that, utilize
using grpc = global::Grpc.Core;and prepend all grpc names withgrpc::(same trick has been used in protobuf generated code and it works well).7