Skip to content

Improve grpclb trace logging.#17533

Merged
markdroth merged 1 commit intogrpc:masterfrom
markdroth:grpclb_trace_logging
Dec 18, 2018
Merged

Improve grpclb trace logging.#17533
markdroth merged 1 commit intogrpc:masterfrom
markdroth:grpclb_trace_logging

Conversation

@markdroth
Copy link
Copy Markdown
Member

@markdroth markdroth commented Dec 17, 2018

Improve grpclb trace logging messages.

@markdroth markdroth added lang/core release notes: no Indicates if PR should not be in release notes labels Dec 17, 2018
@markdroth markdroth requested a review from AspirinSJL December 17, 2018 22:52
@markdroth markdroth requested a review from apolcyn as a code owner December 17, 2018 22:52
@grpc-testing
Copy link
Copy Markdown

****************************************************************

libgrpc.so

     VM SIZE                                                                                            FILE SIZE
 ++++++++++++++ GROWING                                                                              ++++++++++++++
  +0.2%     +32 src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc                           +32  +0.2%
      +2.1%     +32 grpc_core::(anonymous namespace)::GrpcLb::BalancerCallState::OnBalancerMessageReceiv     +32  +2.1%
      +1.4%      +8 grpc_core::(anonymous namespace)::GrpcLb::BalancerCallState::SendClientLoadReportLoc      +8  +1.4%
      +0.7%      +8 grpc_core::(anonymous namespace)::GrpcLb::CreateOrUpdateRoundRobinPolicyLocked() [cl      +8  +0.7%

 -+-+-+-+-+-+-+ MIXED                                                                                +-+-+-+-+-+-+-
  +0.0%    +152 [None]                                                                                   -32  -0.0%

  +0.0%    +184 TOTAL                                                                                      0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]



@grpc-testing
Copy link
Copy Markdown

[trickle] No significant performance differences

@grpc-testing
Copy link
Copy Markdown

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 2,026,958      Total (>)      2,026,850

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
11,325,183      Total (<)     11,325,195

 No significant differences in binary sizes


@grpc-testing
Copy link
Copy Markdown

[microbenchmarks] No significant performance differences

@markdroth
Copy link
Copy Markdown
Member Author

Known issues: #16497 #17463 #17526

@markdroth markdroth merged commit b9fd078 into grpc:master Dec 18, 2018
@markdroth markdroth deleted the grpclb_trace_logging branch December 18, 2018 22:00
@lock lock bot locked as resolved and limited conversation to collaborators Mar 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lang/core release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants