Skip to content

[revert] Revert "Revert "[gprpp] Add ValidationErrors::message retrieval" (#32767)".#32771

Merged
drfloob merged 3 commits intogrpc:masterfrom
drfloob:reland-validation-errors-message
Apr 10, 2023
Merged

[revert] Revert "Revert "[gprpp] Add ValidationErrors::message retrieval" (#32767)".#32771
drfloob merged 3 commits intogrpc:masterfrom
drfloob:reland-validation-errors-message

Conversation

@drfloob
Copy link
Member

@drfloob drfloob commented Apr 1, 2023

This reverts commit 4f444aa, which needed a cherrypick.

@drfloob drfloob requested a review from markdroth as a code owner April 1, 2023 21:22
@drfloob drfloob added disposition/Needs Internal Changes release notes: no Indicates if PR should not be in release notes and removed lang/c++ lang/core labels Apr 1, 2023
@drfloob drfloob changed the title Revert "Revert "[gprpp] Add ValidationErrors::message retrieval" (#32767)" [revert] Revert "Revert "[gprpp] Add ValidationErrors::message retrieval" (#32767)" Apr 1, 2023
@drfloob drfloob requested a review from ctiller April 1, 2023 22:07
@drfloob drfloob changed the title [revert] Revert "Revert "[gprpp] Add ValidationErrors::message retrieval" (#32767)" [revert] Revert "Revert "[gprpp] Add ValidationErrors::message retrieval" (#32767)". Apr 10, 2023
@drfloob drfloob merged commit c268ac2 into grpc:master Apr 10, 2023
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Apr 11, 2023
drfloob added a commit that referenced this pull request Apr 12, 2023
…en client channel resolver" (#32768)" (#32772)

This is a clean, OSS-only revert of
#32632, but depends on
#32771 landing first, which requires a
cherrypick.
XuanWang-Amos pushed a commit to XuanWang-Amos/grpc that referenced this pull request May 1, 2023
XuanWang-Amos pushed a commit to XuanWang-Amos/grpc that referenced this pull request May 1, 2023
…en client channel resolver" (grpc#32768)" (grpc#32772)

This is a clean, OSS-only revert of
grpc#32632, but depends on
grpc#32771 landing first, which requires a
cherrypick.
wanlin31 pushed a commit that referenced this pull request May 18, 2023
…val" (#32767)". (#32771)

This reverts commit 4f444aa, which
needed a cherrypick.
wanlin31 pushed a commit that referenced this pull request May 18, 2023
…en client channel resolver" (#32768)" (#32772)

This is a clean, OSS-only revert of
#32632, but depends on
#32771 landing first, which requires a
cherrypick.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bloat/none imported Specifies if the PR has been imported to the internal repository lang/c++ lang/core per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants