Skip to content

[EventEngine] Track TCP global stats in the PosixEventEngine#34104

Closed
drfloob wants to merge 8 commits intogrpc:masterfrom
drfloob:ee-global-stats
Closed

[EventEngine] Track TCP global stats in the PosixEventEngine#34104
drfloob wants to merge 8 commits intogrpc:masterfrom
drfloob:ee-global-stats

Conversation

@drfloob
Copy link
Copy Markdown
Member

@drfloob drfloob commented Aug 18, 2023

No description provided.

@drfloob drfloob requested a review from ctiller August 18, 2023 17:21
@drfloob drfloob added the release notes: no Indicates if PR should not be in release notes label Aug 18, 2023
@drfloob drfloob mentioned this pull request Aug 18, 2023
Closed
@drfloob
Copy link
Copy Markdown
Member Author

drfloob commented Aug 22, 2023

This can be merged when global stats no longer depends on ExecCtx. Alternatively, an ExecCtx can be created for every call to grpc_core::global_stats()::Increment*, but that seems unnecessary on the fast read/write paths. See #34124 for why it might be challenging to pepper ExecCtx more broadly through the PosixEndpoint code.

@copybara-service copybara-service Bot closed this in 66b478f Jan 2, 2025
copybara-service Bot pushed a commit that referenced this pull request Jan 3, 2025
@drfloob @copybara-github
[benchmark] Log global stats at the end of the QPS benchmarks (#34105)
8caabd5 
Depends on #34104

Closes #34105

COPYBARA_INTEGRATE_REVIEW=#34105 from drfloob:qps-worker-print-global-stats f07bf57
PiperOrigin-RevId: 711780914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctiller ctiller ctiller approved these changes

Assignees

No one assigned

Labels

bloat/low disposition/never stale lang/core per-call-memory/increase per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drfloob @ctiller