[CSM O11Y] Fix issue when CSM optional labels are present in server metrics#35633
Closed
yijiem wants to merge 4 commits intogrpc:masterfrom
Closed
[CSM O11Y] Fix issue when CSM optional labels are present in server metrics#35633yijiem wants to merge 4 commits intogrpc:masterfrom
yijiem wants to merge 4 commits intogrpc:masterfrom
Conversation
yijiem
added
the
release notes: no
yashykt
reviewed
Jan 23, 2024
src/cpp/ext/otel/otel_plugin.h
Outdated
| // Some optional labels may only be set on client or server. We use this enum | ||
| // to specify the entity of the caller for the APIs that need this | ||
| // information. | ||
| enum class Entity { |
Member
There was a problem hiding this comment.
Throughout gRPC Core, we've just been using a simple is_client bool for this. If we were to do this, I would prefer doing it all over.
Member
There was a problem hiding this comment.
+1 -- let's just use a bool here. We're not expecting to have any context other than client or server in the future, so there's no need to leave room for future options.
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
Member
|
I assume this will need to be back-ported to 1.61 before the release goes out. |
yashykt
approved these changes
Jan 23, 2024
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/neutral
labels
markdroth
approved these changes
Jan 23, 2024
markdroth
approved these changes
Jan 23, 2024
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/increase
labels
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/decrease
labels
markdroth
approved these changes
Jan 23, 2024
yijiem
added a commit
to yijiem/grpc
that referenced
this pull request
Jan 24, 2024
…etrics (grpc#35633) <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#35633 COPYBARA_INTEGRATE_REVIEW=grpc#35633 from yijiem:labels-injector-patch 6876243 PiperOrigin-RevId: 600931754
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.