[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT#36223
Closed
tanvi-jagtap wants to merge 1 commit intogrpc:masterfrom
Closed
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT#36223tanvi-jagtap wants to merge 1 commit intogrpc:masterfrom
tanvi-jagtap wants to merge 1 commit intogrpc:masterfrom
Conversation
tanvi-jagtap
added
the
release notes: no
grpc-checks
bot
added
bloat/none
per-call-memory/increase
per-channel-memory/neutral
labels
Vignesh2208
approved these changes
Apr 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - GPR_ASSERT
Replacing GPR_ASSERT with absl CHECK
Will not be replacing CHECK with CHECK_EQ , CHECK_NE etc because there are too many callsites.
This could be done using Cider-V once these changes are submitted if we want to clean up later. Given that we have 4000+ instances of GPR_ASSERT to edit, Doing it manually is too much work for both the author and reviewer.