[OTel C++] Simplify tests#37486
Closed
yashykt wants to merge 1 commit intogrpc:masterfrom
Closed
Conversation
yashykt
added
the
release notes: no
grpc-checks
Bot
added
bloat/none
per-call-memory/increase
per-channel-memory/neutral
labels
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Nov 25, 2024
It is hard to reason about tests if multiple callbacks record values for the same metrics with the same label sets. Closes grpc#37486 COPYBARA_INTEGRATE_REVIEW=grpc#37486 from yashykt:SimplifyOTelPluginTest 3b4d7f9 PiperOrigin-RevId: 663457107
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is hard to reason about tests if multiple callbacks record values for the same metrics with the same label sets.