[ObjC] Fix address sorting issue#38215
Closed
HannahShiSFB wants to merge 2 commits intogrpc:masterfrom
Closed
Conversation
HannahShiSFB
added
kokoro:run
release notes: no
grpc-checks
bot
added
bloat/none
per-call-memory/decrease
per-channel-memory/neutral
labels
HannahShiSFB
force-pushed
the
fix-address-sorting-issue
branch
from
3ad18b8 to
ffa70e0
Compare
HannahShiSFB
force-pushed
the
fix-address-sorting-issue
branch
from
ffa70e0 to
08014bc
Compare
HannahShiSFB
force-pushed
the
fix-address-sorting-issue
branch
from
08014bc to
cc411bb
Compare
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/decrease
labels
HannahShiSFB
force-pushed
the
fix-address-sorting-issue
branch
from
cc411bb to
0e37cd9
Compare
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/neutral
labels
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/increase
labels
HannahShiSFB
added a commit
that referenced
this pull request
Dec 11, 2024
Backport #38215 for 1.69.x ios release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#38025 added address_sorting to src/core/lib/surface/init.cc, this PR add it to objc/swift build dependencies.
This PR fixed grpc/core/master/macos/grpc_basictests_objc_examples failure and all those unit test build failures,
CI Build Failures:
grpc/core/master/macos/grpc_basictests_objc_examples (b/376274777)
Error log
grpc/core/master/macos/grpc_ios_binary_size (b/376274787)
Error log