[build] Remove language tag from BUILD files#38501
Closed
ctiller wants to merge 3 commits intogrpc:masterfrom
Closed
[build] Remove language tag from BUILD files#38501ctiller wants to merge 3 commits intogrpc:masterfrom
language tag from BUILD files#38501ctiller wants to merge 3 commits intogrpc:masterfrom
Conversation
grpc-checks
bot
added
bloat/none
per-call-memory/decrease
per-channel-memory/neutral
labels
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/decrease
labels
ctiller
added
the
release notes: no
veblush
approved these changes
Jan 21, 2025
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Jan 23, 2025
This is only ever set to C++, so removing it from bazel. There are remnants left in cmakefile generation that I'm not planning on cleaning up (looked like some of the yaml/python pieces still use this) Closes grpc#38501 COPYBARA_INTEGRATE_REVIEW=grpc#38501 from ctiller:language c8aee06 PiperOrigin-RevId: 718198572
XuanWang-Amos
pushed a commit
to xrmx/grpc
that referenced
this pull request
Jan 28, 2025
This is only ever set to C++, so removing it from bazel. There are remnants left in cmakefile generation that I'm not planning on cleaning up (looked like some of the yaml/python pieces still use this) Closes grpc#38501 COPYBARA_INTEGRATE_REVIEW=grpc#38501 from ctiller:language c8aee06 PiperOrigin-RevId: 718198572
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Feb 20, 2025
This is only ever set to C++, so removing it from bazel. There are remnants left in cmakefile generation that I'm not planning on cleaning up (looked like some of the yaml/python pieces still use this) Closes grpc#38501 COPYBARA_INTEGRATE_REVIEW=grpc#38501 from ctiller:language c8aee06 PiperOrigin-RevId: 718198572
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only ever set to C++, so removing it from bazel.
There are remnants left in cmakefile generation that I'm not planning on cleaning up (looked like some of the yaml/python pieces still use this)