[PH2] Fixing circular dependency#40204
Closed
tanvi-jagtap wants to merge 5 commits intogrpc:masterfrom
Closed
Conversation
tanvi-jagtap
changed the title
tanvi-jagtap
changed the title
tanvi-jagtap
added
the
release notes: no
grpc-checks
bot
added
bloat/none
per-call-memory/neutral
per-channel-memory/neutral
labels
tanvi-jagtap
changed the title
ananda1066
approved these changes
Jul 14, 2025
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Aug 23, 2025
[PH2] Fixing circular dependency `Http2SettingsManager` needs `frame.h`. Our new validation code in frame.h needs `Http2Settings`. So we split `Http2Settings` and `Http2SettingsManager` into 2 separate header files to resolve the circular dependency. Closes grpc#40204 COPYBARA_INTEGRATE_REVIEW=grpc#40204 from tanvi-jagtap:ph2_fixing_circular_dependency 1771895 PiperOrigin-RevId: 783114803
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[PH2] Fixing circular dependency
Http2SettingsManagerneedsframe.h.Our new validation code in frame.h needs
Http2Settings.So we split
Http2SettingsandHttp2SettingsManagerinto 2 separate header files to resolve the circular dependency.