Closed
Conversation
Automated fix for refs/heads/spiffe_xds
gtcooke94
added
area/security
release notes: no
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/medium
labels
yashykt
approved these changes
Jul 24, 2025
asheshvidyut
pushed a commit
to asheshvidyut/grpc
that referenced
this pull request
Jul 28, 2025
Roll forward after rollback of grpc#39708 with the change to move `JsonLoader` impls from the `spiffe_utils.h` to `spiffe_utils.cc`. There was potential to cause a linker issue with the impls in the header. Closes grpc#40279 COPYBARA_INTEGRATE_REVIEW=grpc#40279 from gtcooke94:spiffe_xds 66fce6d PiperOrigin-RevId: 786762336
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Aug 23, 2025
Roll forward after rollback of grpc#39708 with the change to move `JsonLoader` impls from the `spiffe_utils.h` to `spiffe_utils.cc`. There was potential to cause a linker issue with the impls in the header. Closes grpc#40279 COPYBARA_INTEGRATE_REVIEW=grpc#40279 from gtcooke94:spiffe_xds 66fce6d PiperOrigin-RevId: 786762336
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roll forward after rollback of #39708 with the change to move
JsonLoaderimpls from thespiffe_utils.htospiffe_utils.cc. There was potential to cause a linker issue with the impls in the header.