added anlz osc msg & bpm heartbeat - #39
Conversation
|
Allright, just a quick look-over, haven't run anything yet: The anlz part looks good! I'd like to do the heartbeat a bit differently though. I think a more universal way to do it would be to handle it on the beatkeeper side. Instead of each module separately keeping copies of state and tracking hearbeats, I'd instead suggest just triggering the |
|
makes sense, I just wanted to keep as much of the original code intact, but i pushed another version:
|
Less duplicate code, sync more things.
|
Hey, I did a pass over to make sure everything received the heartbeat! It'd be great if you want to try if it still does what you want it to. It needs a little bit of cleanup and more thorough testing, but other than that I think it's pretty pushable 👍 |
|
Hi @mrmilbe, could you reopen this to target the dev branch? |
changes should be subtle, I added
osc.heartbeat.anlz_path false
osc.heartbeat.bpm false
to the config. If both are false the functionality should remain unchanged.
osc.heartbeat.anlz_path sends the anlz path on the slow heartbeat
osc.heartbeat.bpm sends the bpm on the slow heartbeat additionally to when it changed ( to catch dropped messages)