fix(submodules): remove stale modules/bw-gdlib gitlink breaking CI - #249
Merged
Conversation
Commit 1b353ae (release/v4.9.4) renamed the bw-gdlib submodule from modules/bw-gdlib to bw-gdlib in .gitmodules, but never removed the old gitlink entry from the tree. That left a tracked gitlink at modules/bw-gdlib with no corresponding .gitmodules mapping, so `git submodule sync --recursive && git submodule update --init --recursive` (CircleCI's setup_environment step) fails on every build with: fatal: no submodule mapping found in .gitmodules for path 'modules/bw-gdlib' Removing the dangling gitlink brings the tree's 5 submodule entries back in sync with .gitmodules' 5 declared paths. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Fix(submodules): Remove stale modules/bw-gdlib gitlink breaking CI📱 DescriptionThis PR removes the stale Platform
🎯 Type of Change
📋 ChangesNew Components AddedNone ModificationsNone Removals
📊 Statistics
🔗 Related Issues
🧪 Tests Status
📸 Screenshots/Videos
🎯 ReviewersDraft Status: This PR is currently in draft mode and ready for review feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix(submodules): Remove stale modules/bw-gdlib gitlink breaking CI
📱 Description
This PR removes the stale
modules/bw-gdlibgit submodule that was breaking the CI pipeline. The submodule appears to be no longer maintained or necessary for the project, and its presence was causing build failures during continuous integration.Summary
setup_environmentstep runsgit submodule sync --recursive && git submodule update --init --recursiveon every build, and it's been failing with:bw-gdlibsubmodule frommodules/bw-gdlibtobw-gdlibin.gitmodules, but never removed the old gitlink entry from the git tree. That left a dangling tracked gitlink atmodules/bw-gdlibwith no matching.gitmodulesentry.git rm --cached modules/bw-gdlibto drop the stale gitlink. The tree's 5 submodule entries (android-build-logic,app/src/main/jni/core,app/src/main/secp/secp256k1,bw-gdlib,modules/private-general-purpose) now match.gitmodules' 5 declared paths exactly.Test plan
git submodule statusruns clean with no errors (previously failed with the mapping error above)git ls-files -s | grep 160000) exactly match the 5path =entries in.gitmodulestest-and-buildworkflow passes on this branchCo-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Platform
🎯 Type of Change
📋 Changes
New Components Added
None
Modifications
None
Removals
modules/bw-gdlibgit submodule reference removed to resolve CI build failures caused by stale/unavailable submodule dependency📊 Statistics
🔗 Related Issues
🧪 Tests Status