Core-977 - inject GitHub username into lambda handler and call Mixpanel API directly #855
Conversation
zackproser
requested review from
eak12913,
ebeneliason,
oredavids and
pete0emerson
as code owners
✅ Deploy Preview for pensive-meitner-faaeee ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
zackproser
changed the title
|
|
||
| def lambda_handler(event, context): | ||
| return "Hello from Gruntwork!" | ||
| url = "https://api.mixpanel.com/track" |
scripts/module-tutorial-client.js
Outdated
| githubUsername = 'unknown' | ||
| } | ||
| // Rewrite the %unknown% placeholder in the main.py configuration on the tutorial page | ||
| document.body.innerHTML = document.body.innerHTML.replace('%unknown%', githubUsername); |
Ah yeah - that was actually intended: in the docusaurus config file, to load the new client module script, I needed to call Not sure yet if current build errors are still related to that or not. Yesterday and the day before, Netlify logs were showing me an auth error where it looked like Netlify was unable to fetch the repo itself during the build 🤔 |
- These changes examine the URL's query string params for a github_username and inject it, along with our tutorial service's endpoint, into the user's demo lambda handler code
-Use requests bundled with lambda to avoid dependencies - Fix call to extremely tempermental Mixpanel API
zackproser
force-pushed
the
core-977/extend-module-tutorial
branch
from
a77fd52 to
8281a9a
Compare
|
Thanks for review! |
Relates to: https://github.com/gruntwork-io/dogfood-infrastructure-modules/pull/150
These changes examine the URL's query string params for a github_username and inject it, along with our tutorial service's endpoint, into the user's demo lambda handler code.
The injections are implemented by a new custom client-side script included in this PR. The client side script is designed to only run on our "Deploying your first module" tutorial page, so it should theoretically have minimal impact on the operation of the rest of the docs site.
The injected endpoint is our GW tutorial service's API gateway deployment URL. The customer's demo lambda's Python handler code has also been updated in this PR to call this specific endpoint and return its response, thus completing the round-trip and book-keeping for tracking activations / users who reached our tutorial goal state.
Ideally, I'd like to figure out how to properly define our GW tutorial service's endpoint solely in
docusaurus.config.jsand load it from within the custom client script that handles the value injection on our "Deploying your first module" , but currently when I attempt to follow docusaurus's docs on loading docusaurus config values I get an error about misusing React hooks. I'd like to manage this config centrally so that future PRs to update the endpoint could be one line change.